counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merged PR 2865: Propagate tax exclusive check in hero payments

Browse source 
# Description

This PR propagates tax exclusive check in hero payments for the reporting of Check in Hero.
Additionally, it keeps propagating the amounts with tax inclusiveness in case, at some point, we need them. These are with the new naming convention.

In order not to break anything, the previous amounts are duplicated and aliased in reporting.

Lastly, I spent some time adding some clarifications and documenting payments set to currency and the dependant used for check in hero.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #20046
This commit is contained in:
Oriol Roqué Paniagua 2024-09-17 07:25:09 +00:00
parent cc837ecd7a
commit 7b9ba021c1
5 changed files with 144 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

9
models/reporting/core/core__vr_check_in_cover.sql
View file

@ -27,11 +27,16 @@ select
verification_start_date_utc as verification_start_date_utc,
verification_end_at_utc as verification_end_at_utc,
verification_end_date_utc as verification_end_date_utc,
amount_in_txn_currency as amount_in_txn_currency,
currency as currency,
amount_in_gbp as amount_in_gbp,
payment_status as payment_status,
payment_paid_date_utc as payment_paid_date_utc,
total_amount_in_txn_currency as total_amount_in_txn_currency,
amount_without_taxes_in_txn_currency as amount_without_taxes_in_txn_currency,
total_amount_in_gbp as total_amount_in_gbp,
amount_without_taxes_in_gbp as amount_without_taxes_in_gbp,
total_amount_in_txn_currency as amount_in_txn_currency, -- LEGACY
total_amount_in_gbp as amount_in_gbp, -- LEGACY
checkin_cover_limit_amount_local_curr as checkin_cover_limit_amount_local_curr,
checkin_cover_limit_amount_in_gbp as checkin_cover_limit_amount_in_gbp
from core__vr_check_in_cover