Merged PR 4077: Propagate account code and account name for Xero - reporting models

# Description

Propagate account code and account name for Xero reporting models, specifically:
* xero__credit_note_line_items
* xero__invoice_line_items
* xero__sales_denom_mart

These are already available in intermediate models. This is independent from KPIs, but I feel like we should propagate this to reporting since are useful fields for accounting purposes. Happy to discuss if this needs to be reflected in PBI.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [NA] I have checked for DRY opportunities with other models and docs.
- [NA] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #26531
This commit is contained in:
Oriol Roqué Paniagua 2025-01-16 10:04:41 +00:00
parent ae4f656d54
commit 6aafd605b2
4 changed files with 30 additions and 0 deletions

View file

@ -204,6 +204,14 @@ models:
data_type: text
description: A text based code that describes the Item.
- name: account_code
data_type: text
description: Accounting code for the related account.
- name: account_name
data_type: text
description: Name for the related account.
- name: quantity
data_type: numeric
description: How much of the item is sold in its invoice.
@ -643,6 +651,14 @@ models:
data_type: text
description: A text based code that describes the Item.
- name: account_code
data_type: text
description: Accounting code for the related account.
- name: account_name
data_type: text
description: Name for the related account.
- name: quantity
data_type: numeric
description: How much of the item is credited in this credit note.
@ -1179,6 +1195,14 @@ models:
data_type: text
description: ""
- name: account_code
data_type: text
description: Accounting code for the related account.
- name: account_name
data_type: text
description: Name for the related account.
- name: quantity
data_type: numeric
description: ""

View file

@ -8,6 +8,8 @@ select
id_line_item as id_line_item,
id_item as id_item,
item_code as item_code,
account_code as account_code,
account_name as account_name,
quantity as quantity,
unit_amount as unit_amount,
line_amount_local_curr as line_amount_local_curr,

View file

@ -8,6 +8,8 @@ select
id_line_item as id_line_item,
id_item as id_item,
item_code as item_code,
account_code as account_code,
account_name as account_name,
quantity as quantity,
unit_amount as unit_amount,
line_amount_local_curr as line_amount_local_curr,

View file

@ -7,6 +7,8 @@ select
sdm.id_item as id_item,
sdm.document_class as document_class,
sdm.item_code as item_code,
sdm.account_code as account_code,
sdm.account_name as account_name,
sdm.quantity as quantity,
sdm.unit_amount as unit_amount,
sdm.line_amount_local_curr as line_amount_local_curr,