Addressed comments

This commit is contained in:
Joaquin 2024-11-04 14:29:26 +01:00
parent 21858d4d59
commit 64c3c6d1f0
8 changed files with 75 additions and 54 deletions

View file

@ -480,8 +480,7 @@ models:
description: The dimension or granularity of the metrics.
tests:
- assert_dimension_completeness:
metric_column_names:
- created_bookings
metric_column_name: created_bookings
- accepted_values:
values:
- global
@ -3242,7 +3241,13 @@ models:
tests:
- not_null
- accepted_values:
values: ["0", "01-05", "06-20", "21-60", "61+", "UNSET"]
values:
- "0"
- "01-05"
- "06-20"
- "21-60"
- "61+"
- "UNSET"
- name: main_billing_country_iso_3_per_deal
data_type: character varying
@ -3332,16 +3337,25 @@ models:
The dimension or granularity of the metrics.
tests:
- assert_dimension_completeness:
metric_column_names:
- created_guest_journeys_not_cancelled
- started_guest_journeys_not_cancelled
- completed_guest_journeys_not_cancelled
- created_guest_journeys
- started_guest_journeys
- completed_guest_journeys
metric_column_name: created_guest_journeys_not_cancelled
- assert_dimension_completeness:
metric_column_name: started_guest_journeys_not_cancelled
- assert_dimension_completeness:
metric_column_name: completed_guest_journeys_not_cancelled
- assert_dimension_completeness:
metric_column_name: created_guest_journeys
- assert_dimension_completeness:
metric_column_name: started_guest_journeys
- assert_dimension_completeness:
metric_column_name: completed_guest_journeys
- accepted_values:
values: ["global", "by_deal", "by_has_payment", "by_has_id_check",
"by_billing_country", "by_number_of_listings"]
values:
- global
- by_deal
- by_has_payment
- by_has_id_check
- by_billing_country
- by_number_of_listings
- name: dimension_value
data_type: text
@ -3461,7 +3475,13 @@ models:
tests:
- not_null
- accepted_values:
values: ["0", "01-05", "06-20", "21-60", "61+", "UNSET"]
values:
- "0"
- "01-05"
- "06-20"
- "21-60"
- "61+"
- "UNSET"
- name: main_billing_country_iso_3_per_deal
data_type: character varying
@ -3551,16 +3571,25 @@ models:
The dimension or granularity of the metrics.
tests:
- assert_dimension_completeness:
metric_column_names:
- created_guest_journeys_not_cancelled
- started_guest_journeys_not_cancelled
- completed_guest_journeys_not_cancelled
- created_guest_journeys
- started_guest_journeys
- completed_guest_journeys
metric_column_name: created_guest_journeys_not_cancelled
- assert_dimension_completeness:
metric_column_name: started_guest_journeys_not_cancelled
- assert_dimension_completeness:
metric_column_name: completed_guest_journeys_not_cancelled
- assert_dimension_completeness:
metric_column_name: created_guest_journeys
- assert_dimension_completeness:
metric_column_name: started_guest_journeys
- assert_dimension_completeness:
metric_column_name: completed_guest_journeys
- accepted_values:
values: ["global", "by_deal", "by_has_payment", "by_has_id_check",
"by_billing_country", "by_number_of_listings"]
values:
- global
- by_deal
- by_has_payment
- by_has_id_check
- by_billing_country
- by_number_of_listings
- name: dimension_value
data_type: text