counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Addressed comments

Browse source
This commit is contained in:
Joaquin 2024-11-04 18:15:13 +01:00
parent 392006b71c
commit 5d642d2c77
6 changed files with 43 additions and 57 deletions
Download patch file Download diff file Expand all files Collapse all files

2
models/intermediate/kpis/int_kpis__agg_monthly_check_in_attributed_guest_journeys.sql
View file

@ -28,7 +28,7 @@
sum(started_guest_journeys) as started_guest_journeys, sum(started_guest_journeys) as started_guest_journeys,
sum(completed_guest_journeys) as completed_guest_journeys, sum(completed_guest_journeys) as completed_guest_journeys,
sum(count_csat_score) as count_csat_score, sum(count_csat_score) as count_csat_score,
sum(count_csat_score * average_csat_score)/sum(count_csat_score) as average_csat_score sum(count_csat_score * average_csat_score) / nullif(sum(count_csat_score), 0) as average_csat_score
from {{ ref("int_kpis__metric_monthly_check_in_attributed_guest_journeys") }} from {{ ref("int_kpis__metric_monthly_check_in_attributed_guest_journeys") }}
group by 1, 2, 3, 4 group by 1, 2, 3, 4
{% if not loop.last %} {% if not loop.last %}

2
models/intermediate/kpis/int_kpis__agg_mtd_check_in_attributed_guest_journeys.sql
View file

@ -28,7 +28,7 @@
sum(started_guest_journeys) as started_guest_journeys, sum(started_guest_journeys) as started_guest_journeys,
sum(completed_guest_journeys) as completed_guest_journeys, sum(completed_guest_journeys) as completed_guest_journeys,
sum(count_csat_score) as count_csat_score, sum(count_csat_score) as count_csat_score,
sum(count_csat_score * average_csat_score)/sum(count_csat_score) as average_csat_score sum(count_csat_score * average_csat_score) / nullif(sum(count_csat_score), 0) as average_csat_score
from {{ ref("int_kpis__metric_mtd_check_in_attributed_guest_journeys") }} from {{ ref("int_kpis__metric_mtd_check_in_attributed_guest_journeys") }}
group by 1, 2, 3, 4 group by 1, 2, 3, 4
{% if not loop.last %} {% if not loop.last %}

2
models/intermediate/kpis/int_kpis__metric_daily_check_in_attributed_guest_journeys.sql
View file

@ -78,7 +78,7 @@ select
end end
) as count_csat_score, ) as count_csat_score,
avg( avg(
distinct case case
when gsr.id_verification_request is not null when gsr.id_verification_request is not null
then gsr.experience_rating then gsr.experience_rating
else null else null

2
models/intermediate/kpis/int_kpis__metric_monthly_check_in_attributed_guest_journeys.sql
View file

@ -25,7 +25,7 @@ select
sum(b.started_guest_journeys) as started_guest_journeys, sum(b.started_guest_journeys) as started_guest_journeys,
sum(b.completed_guest_journeys) as completed_guest_journeys, sum(b.completed_guest_journeys) as completed_guest_journeys,
sum(b.count_csat_score) as count_csat_score, sum(b.count_csat_score) as count_csat_score,
sum(b.count_csat_score * b.average_csat_score)/sum(b.count_csat_score) as average_csat_score sum(b.count_csat_score * b.average_csat_score) / nullif(sum(b.count_csat_score), 0) as average_csat_score
from {{ ref("int_kpis__dimension_dates") }} d from {{ ref("int_kpis__dimension_dates") }} d
left join left join
{{ ref("int_kpis__metric_daily_check_in_attributed_guest_journeys") }} b {{ ref("int_kpis__metric_daily_check_in_attributed_guest_journeys") }} b

2
models/intermediate/kpis/int_kpis__metric_mtd_check_in_attributed_guest_journeys.sql
View file

@ -25,7 +25,7 @@ select
sum(b.started_guest_journeys) as started_guest_journeys, sum(b.started_guest_journeys) as started_guest_journeys,
sum(b.completed_guest_journeys) as completed_guest_journeys, sum(b.completed_guest_journeys) as completed_guest_journeys,
sum(b.count_csat_score) as count_csat_score, sum(b.count_csat_score) as count_csat_score,
sum(b.count_csat_score * b.average_csat_score)/sum(b.count_csat_score) as average_csat_score sum(b.count_csat_score * b.average_csat_score) / nullif(sum(b.count_csat_score), 0) as average_csat_score
from {{ ref("int_kpis__dimension_dates") }} d from {{ ref("int_kpis__dimension_dates") }} d
left join left join
{{ ref("int_kpis__metric_daily_check_in_attributed_guest_journeys") }} b {{ ref("int_kpis__metric_daily_check_in_attributed_guest_journeys") }} b

90
models/intermediate/kpis/schema.yml
View file

@ -3290,31 +3290,31 @@ models:
- name: created_guest_journeys_not_cancelled - name: created_guest_journeys_not_cancelled
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys created, excluding cancelled bookings, Accumulated count of daily guest journeys created, excluding cancelled
in a given date and per specified dimension. bookings, in a given date and per specified dimension.
tests: tests:
- not_null - not_null
- name: started_guest_journeys_not_cancelled - name: started_guest_journeys_not_cancelled
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys started, excluding cancelled bookings, Accumulated count of daily guest journeys started, excluding cancelled
in a given date and per specified dimension. bookings, in a given date and per specified dimension.
tests: tests:
- not_null - not_null
- name: completed_guest_journeys_not_cancelled - name: completed_guest_journeys_not_cancelled
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys completed, excluding cancelled bookings, Accumulated count of daily guest journeys completed, excluding cancelled
in a given date and per specified dimension. bookings, in a given date and per specified dimension.
tests: tests:
- not_null - not_null
- name: created_guest_journeys - name: created_guest_journeys
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys created in a given date and Accumulated count of daily guest journeys created in a given date and
per specified dimension. per specified dimension.
tests: tests:
- not_null - not_null
@ -3322,7 +3322,7 @@ models:
- name: started_guest_journeys - name: started_guest_journeys
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys started in a given date and Accumulated count of daily guest journeys started in a given date and
per specified dimension. per specified dimension.
tests: tests:
- not_null - not_null
@ -3330,7 +3330,7 @@ models:
- name: completed_guest_journeys - name: completed_guest_journeys
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys completed in a given date and Accumulated count of daily guest journeys completed in a given date and
per specified dimension. per specified dimension.
tests: tests:
- not_null - not_null
@ -3338,17 +3338,13 @@ models:
- name: count_csat_score - name: count_csat_score
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys with CSAT (customer satisfaction score) Accumulated count of guest journeys with CSAT
in a given date and per specified dimension. (customer satisfaction score) in a given date, dimension, and value..
tests:
- dbt_expectations.expect_column_values_to_be_between:
min_value: 0
strictly: false
- name: average_csat_score - name: average_csat_score
data_type: numeric data_type: numeric
description: | description: |
Average daily CSAT score in a given date and per specified dimension. Accumulated average CSAT score in a given date, dimension, and value.
tests: tests:
- dbt_expectations.expect_column_values_to_be_between: - dbt_expectations.expect_column_values_to_be_between:
min_value: 0 min_value: 0
@ -3468,17 +3464,14 @@ models:
- name: count_csat_score - name: count_csat_score
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys with CSAT (customer satisfaction score) Monthly aggregated count of guest journeys with CSAT
in a given date and per specified dimension. (customer satisfaction score) in a given date, dimension, and value.
tests:
- dbt_expectations.expect_column_values_to_be_between:
min_value: 0
strictly: false
- name: average_csat_score - name: average_csat_score
data_type: numeric data_type: numeric
description: | description: |
Average daily CSAT score in a given date and per specified dimension. Monthly aggregated average CSAT score in a given date,
dimension, and value.
tests: tests:
- dbt_expectations.expect_column_values_to_be_between: - dbt_expectations.expect_column_values_to_be_between:
min_value: 0 min_value: 0
@ -3574,31 +3567,31 @@ models:
- name: created_guest_journeys_not_cancelled - name: created_guest_journeys_not_cancelled
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys created, excluding cancelled bookings, Accumulated count of daily guest journeys created, excluding cancelled
in a given date and per specified dimension. bookings, in a given date and per specified dimension.
tests: tests:
- not_null - not_null
- name: started_guest_journeys_not_cancelled - name: started_guest_journeys_not_cancelled
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys started, excluding cancelled bookings, Accumulated count of daily guest journeys started, excluding cancelled
in a given date and per specified dimension. bookings, in a given date and per specified dimension.
tests: tests:
- not_null - not_null
- name: completed_guest_journeys_not_cancelled - name: completed_guest_journeys_not_cancelled
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys completed, excluding cancelled bookings, Accumulated count of daily guest journeys completed, excluding cancelled
in a given date and per specified dimension. bookings, in a given date and per specified dimension.
tests: tests:
- not_null - not_null
- name: created_guest_journeys - name: created_guest_journeys
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys created in a given date and Accumulated count of daily guest journeys created in a given date and
per specified dimension. per specified dimension.
tests: tests:
- not_null - not_null
@ -3606,7 +3599,7 @@ models:
- name: started_guest_journeys - name: started_guest_journeys
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys started in a given date and Accumulated count of daily guest journeys started in a given date and
per specified dimension. per specified dimension.
tests: tests:
- not_null - not_null
@ -3614,7 +3607,7 @@ models:
- name: completed_guest_journeys - name: completed_guest_journeys
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys completed in a given date and Accumulated count of daily guest journeys completed in a given date and
per specified dimension. per specified dimension.
tests: tests:
- not_null - not_null
@ -3622,17 +3615,13 @@ models:
- name: count_csat_score - name: count_csat_score
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys with CSAT (customer satisfaction score) Accumulated count of guest journeys with CSAT
in a given date and per specified dimension. (customer satisfaction score) in a given date, dimension, and value..
tests:
- dbt_expectations.expect_column_values_to_be_between:
min_value: 0
strictly: false
- name: average_csat_score - name: average_csat_score
data_type: numeric data_type: numeric
description: | description: |
Average daily CSAT score in a given date and per specified dimension. Accumulated average CSAT score in a given date, dimension, and value.
tests: tests:
- dbt_expectations.expect_column_values_to_be_between: - dbt_expectations.expect_column_values_to_be_between:
min_value: 0 min_value: 0
@ -3704,7 +3693,7 @@ models:
- name: created_guest_journeys_not_cancelled - name: created_guest_journeys_not_cancelled
data_type: numeric data_type: numeric
description: | description: |
Monthly aggregated count of guest journeys created, excluding Month-to-date aggregated count of guest journeys created, excluding
cancelled bookings, for a given date, dimension, and value. cancelled bookings, for a given date, dimension, and value.
tests: tests:
- not_null - not_null
@ -3712,7 +3701,7 @@ models:
- name: started_guest_journeys_not_cancelled - name: started_guest_journeys_not_cancelled
data_type: numeric data_type: numeric
description: | description: |
Monthly aggregated count of guest journeys started, excluding Month-to-date aggregated count of guest journeys started, excluding
cancelled bookings, for a given date, dimension, and value. cancelled bookings, for a given date, dimension, and value.
tests: tests:
- not_null - not_null
@ -3720,7 +3709,7 @@ models:
- name: completed_guest_journeys_not_cancelled - name: completed_guest_journeys_not_cancelled
data_type: numeric data_type: numeric
description: | description: |
Monthly aggregated count of guest journeys completed, excluding Month-to-date aggregated count of guest journeys completed, excluding
cancelled bookings, for a given date, dimension, and value. cancelled bookings, for a given date, dimension, and value.
tests: tests:
- not_null - not_null
@ -3728,7 +3717,7 @@ models:
- name: created_guest_journeys - name: created_guest_journeys
data_type: numeric data_type: numeric
description: | description: |
Monthly aggregated count of guest journeys created for a given date, Month-to-date aggregated count of guest journeys created for a given date,
dimension, and value. dimension, and value.
tests: tests:
- not_null - not_null
@ -3736,7 +3725,7 @@ models:
- name: started_guest_journeys - name: started_guest_journeys
data_type: numeric data_type: numeric
description: | description: |
Monthly aggregated count of guest journeys started for a given date, Month-to-date aggregated count of guest journeys started for a given date,
dimension, and value. dimension, and value.
tests: tests:
- not_null - not_null
@ -3744,7 +3733,7 @@ models:
- name: completed_guest_journeys - name: completed_guest_journeys
data_type: numeric data_type: numeric
description: | description: |
Monthly aggregated count of guest journeys completed for a given date, Month-to-date aggregated count of guest journeys completed for a given date,
dimension, and value. dimension, and value.
tests: tests:
- not_null - not_null
@ -3752,17 +3741,14 @@ models:
- name: count_csat_score - name: count_csat_score
data_type: numeric data_type: numeric
description: | description: |
Count of daily guest journeys with CSAT (customer satisfaction score) Month-to-date aggregated count of guest journeys with CSAT
in a given date and per specified dimension. (customer satisfaction score) in a given date, dimension, and value.
tests:
- dbt_expectations.expect_column_values_to_be_between:
min_value: 0
strictly: false
- name: average_csat_score - name: average_csat_score
data_type: numeric data_type: numeric
description: | description: |
Average daily CSAT score in a given date and per specified dimension. Month-to-date aggregated average CSAT score in a given date,
dimension, and value.
tests: tests:
- dbt_expectations.expect_column_values_to_be_between: - dbt_expectations.expect_column_values_to_be_between:
min_value: 0 min_value: 0