counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merged PR 3279: Remove unused code: additive contribution to churn and its metrics

Browse source 
# Description

Simplifies the code for the models:
* int_monthly_12m_window_contribution_by_deal
* int_monthly_churn_metrics

By just removing the additive contribution approach. This also reduces the schema file information of these 2 models. I also adapted the description to clarify the state of the models.

No rush to merge this.

# Checklist

- [X] The edited models and dependants run properly with production data.
- [X] The edited models are sufficiently documented.
- [X] The edited models contain PK tests, and I've ran and passed them.
- [X] I have checked for DRY opportunities with other models and docs.
- [X] I've picked the right materialization for the affected models.

# Other

- [ ] Check if a full-refresh is required after this PR is merged.

Related work items: #22691
This commit is contained in:
Oriol Roqué Paniagua 2024-10-24 12:47:38 +00:00
parent 689ea53c11
commit 5c1f6f88f2
3 changed files with 5 additions and 132 deletions
Download patch file Download diff file Expand all files Collapse all files

30
models/intermediate/cross/int_monthly_churn_metrics.sql
View file

@ -19,27 +19,6 @@ with
m12wc.date,
{{ dimension.dimension }} as dimension,
{{ dimension.dimension_value }} as dimension_value,
sum(
case
when m12wc.deal_lifecycle_state in {{ churn_lifecycle_states }}
then m12wc.total_revenue_12m_additive_contribution
else 0
end
) as total_revenue_churn_additive_contribution,
sum(
case
when m12wc.deal_lifecycle_state in {{ churn_lifecycle_states }}
then m12wc.created_bookings_12m_additive_contribution
else 0
end
) as created_bookings_churn_additive_contribution,
sum(
case
when m12wc.deal_lifecycle_state in {{ churn_lifecycle_states }}
then m12wc.listings_booked_in_month_12m_additive_contribution
else 0
end
) as listings_booked_in_month_churn_additive_contribution,
sum(
case
when m12wc.deal_lifecycle_state in {{ churn_lifecycle_states }}
@ -90,15 +69,6 @@ select
d.dimension_value,
d.is_end_of_month,
d.is_current_month,
cast(
c.total_revenue_churn_additive_contribution as numeric(19, 6)
) as total_revenue_churn_additive_contribution,
cast(
c.created_bookings_churn_additive_contribution as numeric(19, 6)
) as created_bookings_churn_additive_contribution,
cast(
c.listings_booked_in_month_churn_additive_contribution as numeric(19, 6)
) as listings_booked_in_month_churn_additive_contribution,
cast(
c.total_revenue_churn_average_contribution as numeric(19, 6)
) as total_revenue_churn_average_contribution,