Addressed comments

This commit is contained in:
Joaquin Ossa 2024-12-02 10:54:29 +01:00
parent 126e702c6e
commit 54df02cac8
3 changed files with 50 additions and 0 deletions

View file

@ -7,6 +7,7 @@ select
-- Dimensions --
coalesce(icbs.id_deal, 'UNSET') as id_deal,
case when icbsd.is_upgraded_service then 'YES' else 'NO' end as is_upgraded_service,
coalesce(icbsd.service_business_type, 'UNSET') as service_business_type,
coalesce(icbs.new_dash_version, 'UNSET') as new_dash_version,
coalesce(
icd.main_billing_country_iso_3_per_deal, 'UNSET'

View file

@ -5438,6 +5438,22 @@ models:
- "YES"
- "NO"
- name: service_business_type
data_type: string
description: |
Identifies the service type (Screening, Deposit Management, Protection)
according to New Pricing documentation.
Cannot be null.
tests:
- not_null
- accepted_values:
values:
- "SCREENING"
- "PROTECTION"
- "DEPOSIT_MANAGEMENT"
- "UNKNOWN"
- "UNSET"
- name: new_dash_version
data_type: string
description: |
@ -5525,6 +5541,22 @@ models:
tests:
- not_null
- name: service_business_type
data_type: string
description: |
Identifies the service type (Screening, Deposit Management, Protection)
according to New Pricing documentation.
Cannot be null.
tests:
- not_null
- accepted_values:
values:
- "SCREENING"
- "PROTECTION"
- "DEPOSIT_MANAGEMENT"
- "UNKNOWN"
- "UNSET"
- name: is_upgraded_service
data_type: string
description: |
@ -5632,6 +5664,22 @@ models:
tests:
- not_null
- name: service_business_type
data_type: string
description: |
Identifies the service type (Screening, Deposit Management, Protection)
according to New Pricing documentation.
Cannot be null.
tests:
- not_null
- accepted_values:
values:
- "SCREENING"
- "PROTECTION"
- "DEPOSIT_MANAGEMENT"
- "UNKNOWN"
- "UNSET"
- name: is_upgraded_service
data_type: string
description: |