From 4f6728003a30f7188f10c48cc60eb2191d604907 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oriol=20Roqu=C3=A9=20Paniagua?= Date: Thu, 13 Jun 2024 14:53:58 +0000 Subject: [PATCH] Merged PR 2029: Guest Journey - start date based on used link Added verification estimated started at/date utc. Ensured continuity for existing reports I also noticed I missed one propagation of the end date, it's fixed here. Note: changed the naming from 'start' to 'started' since we already had 'completed' and 'used_link' Related work items: #17268 --- .../core/int_core__booking_charge_events.sql | 4 ++-- .../core/int_core__verification_requests.sql | 11 +++++------ .../intermediate/core/int_core__vr_check_in_cover.sql | 8 ++++---- models/reporting/core/core__verification_requests.sql | 4 ++-- 4 files changed, 13 insertions(+), 14 deletions(-) diff --git a/models/intermediate/core/int_core__booking_charge_events.sql b/models/intermediate/core/int_core__booking_charge_events.sql index 2cfc1ea..8e635bf 100644 --- a/models/intermediate/core/int_core__booking_charge_events.sql +++ b/models/intermediate/core/int_core__booking_charge_events.sql @@ -12,7 +12,7 @@ with when pp.price_plan_charged_by_type = 'CheckInDate' then b.check_in_at_utc when pp.price_plan_charged_by_type in ('VerificationStartDate', 'All') - then vr.verification_start_at_utc + then vr.verification_estimated_started_at_utc end as booking_fee_charge_at_utc from stg_core__booking b left join @@ -30,7 +30,7 @@ with then coalesce( ( - vr.verification_start_at_utc + vr.verification_estimated_started_at_utc between pp.start_at_utc and pp.end_at_utc ), false diff --git a/models/intermediate/core/int_core__verification_requests.sql b/models/intermediate/core/int_core__verification_requests.sql index d569926..fbe13da 100644 --- a/models/intermediate/core/int_core__verification_requests.sql +++ b/models/intermediate/core/int_core__verification_requests.sql @@ -3,7 +3,6 @@ with stg_core__verification_request as ( select * from {{ ref("stg_core__verification_request") }} ), - int_core__unified_user as (select * from {{ ref("int_core__unified_user") }}), int_core__verification_request_completeness as ( select * from {{ ref("int_core__verification_request_completeness") }} ), @@ -29,8 +28,8 @@ select vr.guest_phone_number, vr.telephone_code, vr.guest_phone_number_2, - guest.joined_at_utc as verification_start_at_utc, - guest.joined_date_utc as verification_start_date_utc, + vr.link_used_at_utc as verification_estimated_started_at_utc, + vr.link_used_date_utc as verification_estimated_started_date_utc, vrcd.estimated_completed_at_utc as verification_estimated_completed_at_utc, vrcd.estimated_completed_date_utc as verification_estimated_completed_date_utc, vr.link_used_at_utc, @@ -53,9 +52,9 @@ select vr.updated_date_utc, vr.dwh_extracted_at_utc from stg_core__verification_request vr -left join int_core__unified_user guest on vr.id_user_guest = guest.id_user left join int_core__verification_request_completeness completeness on vr.id_verification_request = completeness.id_verification_request -left join int_core__verification_request_completed_date vrcd -on vr.id_verification_request = vrcd.id_verification_request +left join + int_core__verification_request_completed_date vrcd + on vr.id_verification_request = vrcd.id_verification_request diff --git a/models/intermediate/core/int_core__vr_check_in_cover.sql b/models/intermediate/core/int_core__vr_check_in_cover.sql index eda2134..f55d2fd 100644 --- a/models/intermediate/core/int_core__vr_check_in_cover.sql +++ b/models/intermediate/core/int_core__vr_check_in_cover.sql @@ -60,10 +60,10 @@ select b.check_in_date_utc, b.check_out_at_utc, b.check_out_date_utc, - vr.verification_start_at_utc, - vr.verification_start_date_utc, - vr.verification_end_at_utc, - vr.verification_end_date_utc, + vr.verification_estimated_started_at_utc as verification_start_at_utc, + vr.verification_estimated_started_date_utc as verification_start_date_utc, + vr.verification_estimated_completed_at_utc as verification_end_at_utc, + vr.verification_estimated_completed_date_utc as verification_end_date_utc, vr.link_used_at_utc, vr.link_used_date_utc, vr.expire_at_utc, diff --git a/models/reporting/core/core__verification_requests.sql b/models/reporting/core/core__verification_requests.sql index 9a7480d..0fdcca7 100644 --- a/models/reporting/core/core__verification_requests.sql +++ b/models/reporting/core/core__verification_requests.sql @@ -22,8 +22,8 @@ select guest_phone_number as guest_phone_number, telephone_code as telephone_code, guest_phone_number_2 as guest_phone_number_2, - verification_start_at_utc as verification_start_at_utc, - verification_start_date_utc as verification_start_date_utc, + verification_estimated_started_at_utc as verification_start_at_utc, + verification_estimated_started_date_utc as verification_start_date_utc, verification_estimated_completed_at_utc as verification_end_at_utc, verification_estimated_completed_date_utc as verification_end_date_utc, link_used_at_utc as link_used_at_utc,