Merged PR 4031: Host Resolutions KPIs bugfix
# Description Ensure only Authorised states are selected in bank transactions for Host Resolutions KPIs. Waiting for final confirmation from Suzannah but I'm pretty sure about this since it's consistent with the P&L (and does not make sense to consider DELETED bank transactions anyway) For reference, here's the current values in prod for `xero_host_resolution_amount_paid_in_gbp` (top3): * 2024-12-31 -74318 * 2024-11-30 -87935 * 2024-10-31 -73840 and here the same with this fix. Note that the difference is mostly in November: * 2024-12-31 -73581 * 2024-11-30 -74803 * 2024-10-31 -72473 # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [X] I have checked for DRY opportunities with other models and docs. - [X] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #26247
This commit is contained in:
parent
6ace9230e9
commit
3fe9ac140e
1 changed files with 2 additions and 0 deletions
|
|
@ -1,4 +1,5 @@
|
|||
{% set resolutions_host_payment_account_name = "('RESOLUTIONS - HOST PAYMENT')" %}
|
||||
{% set relevant_transaction_status = "('AUTHORISED')" %}
|
||||
|
||||
{{ config(materialized="table", unique_key=["date", "id_deal"]) }}
|
||||
select
|
||||
|
|
@ -20,6 +21,7 @@ inner join
|
|||
{{ ref("int_xero__bank_transaction_line_items") }} as ixbtli
|
||||
on ixbt.id_bank_transaction = ixbtli.id_bank_transaction
|
||||
and upper(ixbtli.account_name) in {{ resolutions_host_payment_account_name }}
|
||||
and upper(ixbt.transaction_status) in {{ relevant_transaction_status }}
|
||||
left join {{ ref("int_xero__contacts") }} as ixc on ixc.id_contact = ixbt.id_contact
|
||||
left join {{ ref("int_core__deal") }} as icd on ixc.id_deal = icd.id_deal
|
||||
left join
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue