counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

addressed comments

Browse source
This commit is contained in:
Joaquin Ossa 2025-01-14 17:25:59 +01:00
parent 42cea78b2c
commit 32251fa5e9
2 changed files with 14 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
models/intermediate/kpis/int_kpis__dimension_deals.sql
View file

@ -61,8 +61,8 @@ with
min( min(
coalesce(hd.deal_start_month, cd.deal_start_month) coalesce(hd.deal_start_month, cd.deal_start_month)
) as effective_deal_start_month, ) as effective_deal_start_month,
min(hd.deal_cancellation_date) as effective_deal_cancellation_date_utc, min(hd.deal_cancellation_date) as hubspot_deal_cancellation_date_utc,
min(hd.deal_cancellation_month) as effective_deal_cancellation_month, min(hd.deal_cancellation_month) as hubspot_deal_cancellation_month,
min(hd.hubspot_listing_segmentation) as hubspot_listing_segmentation min(hd.hubspot_listing_segmentation) as hubspot_listing_segmentation
from hubspot_deals hd from hubspot_deals hd
full outer join core_deals cd on hd.id_deal = cd.id_deal full outer join core_deals cd on hd.id_deal = cd.id_deal
@ -78,8 +78,8 @@ select
cd.main_billing_country_iso_3_per_deal, cd.main_billing_country_iso_3_per_deal,
cd.effective_deal_start_date_utc, cd.effective_deal_start_date_utc,
cd.effective_deal_start_month, cd.effective_deal_start_month,
cd.effective_deal_cancellation_date_utc, cd.hubspot_deal_cancellation_date_utc,
cd.effective_deal_cancellation_month, cd.hubspot_deal_cancellation_month,
cd.hubspot_listing_segmentation cd.hubspot_listing_segmentation
from combined_deals cd from combined_deals cd
left join integrations_per_deal ipd on cd.id_deal = ipd.id_deal left join integrations_per_deal ipd on cd.id_deal = ipd.id_deal

16
models/intermediate/kpis/schema.yml
View file

@ -478,22 +478,26 @@ models:
- name: effective_deal_start_month - name: effective_deal_start_month
data_type: date data_type: date
description: | description: |
Month of the starting date of the deal. This field represents the first day of the month of the effective
start date of the deal. This is obtained by truncating the effective
deal start date to the month.
data_tests: data_tests:
- not_null - not_null
- name: effective_deal_cancellation_date_utc - name: hubspot_deal_cancellation_date_utc
data_type: date data_type: date
description: | description: |
Effective date at which the deal cancelled it's partnership with Superhog. Effective date at which the deal cancelled it's partnership with Superhog.
- name: effective_deal_cancellation_month - name: hubspot_deal_cancellation_month
data_type: date data_type: date
description: | description: |
Month of the cancellation date of the deal. This field represents the first day of the month of the cancellation date
of the deal. This is obtained by truncating the cancellation deal date
to the month.
- name: hubspot_listing_segmentation - name: hubspot_listing_segmentation
data_type: integer data_type: integer
description: | description: |
Number of properties managed by the deal according Segment value based on the number of properties managed by the deal
to what was set in HubSpot. according to what was set in HubSpot.
data_tests: data_tests:
- accepted_values: - accepted_values:
values: values: