counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merged PR 2246: KPIs refactor: naming convention and PBI sources replication

Browse source 
Changing naming to follow convention.
This PR has the following changes:
- the model `int_core__mtd_aggregated_metrics` has been moved to cross and changed the name to `int_mtd_aggregated_metrics`
- the model `int_core__monthly_aggregated_metrics_history_by_deal` has been moved to cross and changed the name to `int_monthly_aggregated_metrics_history_by_deal`
- the reporting models `core__mtd_aggregated_metrics` and `core__monthly_aggregated_metrics_history_by_deal` now source the `int_mtd_aggregated_metrics` and `int_monthly_aggregated_metrics_history_by_deal` to avoid breaking the production dashboard
- the reporting models have been duplicated from core into general with the correct names, i.e., `mtd_aggregated_metrics` and `monthly_aggregated_metrics_history_by_deal`
- Documentation has been moved in intermediate and replicated in reporting, adding comments on the currently in use models that are going to die soon.

This will allow for a transition of the PBI dashboard from one source to another. Exposures file still not touched since technically the report is still sourcing the 'legacy' models. Documentation of the refactor here: https://www.notion.so/knowyourguest-superhog/Refactoring-Business-KPIs-5deb6aadddb34884ae90339402ac16e3

Related work items: #18202
This commit is contained in:
Oriol Roqué Paniagua 2024-07-09 15:14:50 +00:00
parent 976ac70949
commit 20e7220ffe
10 changed files with 350 additions and 138 deletions
Download patch file Download diff file Expand all files Collapse all files

6
models/reporting/core/core__monthly_aggregated_metrics_history_by_deal.sql
View file

@ -1,6 +1,6 @@
with
int_core__monthly_aggregated_metrics_history_by_deal as (
select * from {{ ref("int_core__monthly_aggregated_metrics_history_by_deal") }}
int_monthly_aggregated_metrics_history_by_deal as (
select * from {{ ref("int_monthly_aggregated_metrics_history_by_deal") }}
)
select
@ -25,4 +25,4 @@ select
listings_booked_in_month as listings_booked_in_month,
listings_booked_in_6_months as listings_booked_in_6_months,
listings_booked_in_12_months as listings_booked_in_12_months
from int_core__monthly_aggregated_metrics_history_by_deal
from int_monthly_aggregated_metrics_history_by_deal

6
models/reporting/core/core__mtd_aggregated_metrics.sql
View file

@ -1,6 +1,6 @@
with
int_core__mtd_aggregated_metrics as (
select * from {{ ref("int_core__mtd_aggregated_metrics") }}
int_mtd_aggregated_metrics as (
select * from {{ ref("int_mtd_aggregated_metrics") }}
)
select
@ -17,4 +17,4 @@ select
value as value,
previous_year_value as previous_year_value,
relative_increment as relative_increment
from int_core__mtd_aggregated_metrics
from int_mtd_aggregated_metrics

8
models/reporting/core/schema.yaml
View file

@ -569,6 +569,10 @@ models:
- name: core__mtd_aggregated_metrics
description: |
IMPORTANT: This model has moved to the general tab, into the mtd_aggregated_metrics
Deprecated. This model will be burned to the ground.
This model aggregates the historic information of our business by providing
different metrics computed at global level.
It's the main source of information for the Main KPIs reporting, specifically
@ -668,6 +672,10 @@ models:
- name: core__monthly_aggregated_metrics_history_by_deal
description: |
IMPORTANT: This model has moved to the general tab, into the monthly_aggregated_metrics_history_by_deal
Deprecated. This model will be burned to the ground.
This model aggregates the monthly historic information regarding the different metrics computed
at deal level. The primary sources of data are the `int_core__monthly_XXXXX_history_by_deal`
models which contain the raw metrics data per source.