addressed comments

This commit is contained in:
Joaquin 2025-06-03 14:17:47 +02:00
parent d50442e887
commit 1b362024f1

View file

@ -4,9 +4,6 @@ with
int_xero__invoices as (select * from {{ ref("int_xero__invoices") }}),
int_xero__credit_notes as (select * from {{ ref("int_xero__credit_notes") }}),
int_xero__contacts as (select * from {{ ref("int_xero__contacts") }}),
stg_seed__accounting_aggregations as (
select * from {{ ref("stg_seed__accounting_aggregations") }}
),
amount_due_deals as (
select
c.id_contact as id_contact,
@ -14,12 +11,12 @@ with
c.contact_name as contact_name,
i.total_due_in_gbp
from int_xero__invoices i
left join int_xero__contacts c on c.id_contact = i.id_contact
inner join int_xero__contacts c on c.id_contact = i.id_contact
where i.invoice_status = {{ pending_transactions }} and c.id_deal is not null
union all
select c.id_contact, c.id_deal, c.contact_name, cn.remaining_credit_in_gbp * -1
from int_xero__credit_notes cn
left join int_xero__contacts c on c.id_contact = cn.id_contact
inner join int_xero__contacts c on c.id_contact = cn.id_contact
where
cn.credit_note_status = {{ pending_transactions }} and c.id_deal is not null
)