From 1b30fbbca9d69b9c83e50d8d255f903a253c9d25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oriol=20Roqu=C3=A9=20Paniagua?= Date: Tue, 3 Sep 2024 13:34:08 +0000 Subject: [PATCH] Merged PR 2724: Removing coalesce from gbp conversion in int_core__host_booking_fees # Description Removing coalesce from gbp conversion in `int_core__host_booking_fees` # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [X] I have checked for DRY opportunities with other models and docs. **Message sent in data team channel** - [X] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. --- models/intermediate/core/int_core__host_booking_fees.sql | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/models/intermediate/core/int_core__host_booking_fees.sql b/models/intermediate/core/int_core__host_booking_fees.sql index 020975a..246c904 100644 --- a/models/intermediate/core/int_core__host_booking_fees.sql +++ b/models/intermediate/core/int_core__host_booking_fees.sql @@ -18,9 +18,7 @@ select coalesce(db.is_duplicate_booking, false) as is_duplicate_booking, bce.booking_fee_local, uu.account_currency_iso4217, - coalesce( - ser.rate * bce.booking_fee_local, bce.booking_fee_local - ) as booking_fee_in_gbp, + ser.rate * bce.booking_fee_local as booking_fee_in_gbp, bce.booking_fee_charge_at_utc, bce.booking_fee_charge_date_utc from stg_core__booking b