Addressed comments

This commit is contained in:
Joaquin Ossa 2024-11-26 10:16:08 +01:00
parent bede588062
commit 0f5eb5fba2
5 changed files with 14 additions and 11 deletions

View file

@ -4,7 +4,7 @@
with with
-- Retrieve recent data based on the defined days_to_consider -- Retrieve recent data based on the defined days_to_consider
recent_data as ( recent_data as (
select * select date_day, {{ column_name }}
from {{ model }} from {{ model }}
where where
date_day between ( date_day between (
@ -20,8 +20,11 @@
outliers as ( outliers as (
select select
{{ column_name }} as value, {{ column_name }} as value,
abs({{ column_name }} - metrics_stats.avg_value) (abs({{ column_name }} - metrics_stats.avg_value))
> (metrics_stats.stddev_value * {{ sigma_threshold }}) as is_outlier / (metrics_stats.stddev_value) as absolute_deviation_z_score,
(abs({{ column_name }} - metrics_stats.avg_value))
/ (metrics_stats.stddev_value)
> {{ sigma_threshold }} as is_outlier
from {{ model }} from {{ model }}
cross join metrics_stats cross join metrics_stats
where date_day = current_date - interval '1 day' where date_day = current_date - interval '1 day'

View file

@ -93,7 +93,7 @@ select
sum(gk.created_guest_journeys) as created_guest_journeys, sum(gk.created_guest_journeys) as created_guest_journeys,
sum(gk.started_guest_journeys) as started_guest_journeys, sum(gk.started_guest_journeys) as started_guest_journeys,
sum(gk.completed_guest_journeys) as completed_guest_journeys, sum(gk.completed_guest_journeys) as completed_guest_journeys,
sum(gk.count_csat_score) as count_csat_score, sum(gk.count_csat_score) as total_csat_score_count,
case case
when sum(gk.count_csat_score) > 0 when sum(gk.count_csat_score) > 0
then sum(gk.average_csat_score * gk.count_csat_score) / sum(gk.count_csat_score) then sum(gk.average_csat_score * gk.count_csat_score) / sum(gk.count_csat_score)
@ -115,7 +115,7 @@ select
sum(gk_py.created_guest_journeys) as py_created_guest_journeys, sum(gk_py.created_guest_journeys) as py_created_guest_journeys,
sum(gk_py.started_guest_journeys) as py_started_guest_journeys, sum(gk_py.started_guest_journeys) as py_started_guest_journeys,
sum(gk_py.completed_guest_journeys) as py_completed_guest_journeys, sum(gk_py.completed_guest_journeys) as py_completed_guest_journeys,
sum(gk_py.count_csat_score) as py_count_csat_score, sum(gk_py.count_csat_score) as py_total_csat_score_count,
case case
when sum(gk_py.count_csat_score) > 0 when sum(gk_py.count_csat_score) > 0
then then

View file

@ -5180,7 +5180,7 @@ models:
Count of daily guest journeys completed in a given date and Count of daily guest journeys completed in a given date and
per specified dimension. per specified dimension.
- name: count_csat_score - name: total_csat_score_count
data_type: bigint data_type: bigint
description: | description: |
Count of daily guest journeys with CSAT (customer satisfaction score) Count of daily guest journeys with CSAT (customer satisfaction score)
@ -5251,7 +5251,7 @@ models:
Count of daily guest journeys completed on the same date in the previous year, Count of daily guest journeys completed on the same date in the previous year,
segmented by the specified dimension. segmented by the specified dimension.
- name: py_count_csat_score - name: py_total_csat_score_count
data_type: bigint data_type: bigint
description: | description: |
Count of daily guest journeys with CSAT (customer satisfaction score) Count of daily guest journeys with CSAT (customer satisfaction score)

View file

@ -15,7 +15,7 @@ select
created_guest_journeys as created_guest_journeys, created_guest_journeys as created_guest_journeys,
started_guest_journeys as started_guest_journeys, started_guest_journeys as started_guest_journeys,
completed_guest_journeys as completed_guest_journeys, completed_guest_journeys as completed_guest_journeys,
count_csat_score as count_csat_score, total_csat_score_count as total_csat_score_count,
average_csat_score as average_csat_score, average_csat_score as average_csat_score,
deposit_fees_in_gbp as deposit_fees_in_gbp, deposit_fees_in_gbp as deposit_fees_in_gbp,
waiver_payments_in_gbp as waiver_payments_in_gbp, waiver_payments_in_gbp as waiver_payments_in_gbp,
@ -28,7 +28,7 @@ select
py_created_guest_journeys as py_created_guest_journeys, py_created_guest_journeys as py_created_guest_journeys,
py_started_guest_journeys as py_started_guest_journeys, py_started_guest_journeys as py_started_guest_journeys,
py_completed_guest_journeys as py_completed_guest_journeys, py_completed_guest_journeys as py_completed_guest_journeys,
py_count_csat_score as py_count_csat_score, py_total_csat_score_count as py_total_csat_score_count,
py_average_csat_score as py_average_csat_score, py_average_csat_score as py_average_csat_score,
py_deposit_fees_in_gbp as py_deposit_fees_in_gbp, py_deposit_fees_in_gbp as py_deposit_fees_in_gbp,
py_waiver_payments_in_gbp as py_waiver_payments_in_gbp, py_waiver_payments_in_gbp as py_waiver_payments_in_gbp,

View file

@ -109,7 +109,7 @@ models:
tests: tests:
- kpis_outlier_detector - kpis_outlier_detector
- name: count_csat_score - name: total_csat_score_count
data_type: bigint data_type: bigint
description: | description: |
Count of daily guest journeys with CSAT (customer satisfaction score) Count of daily guest journeys with CSAT (customer satisfaction score)
@ -190,7 +190,7 @@ models:
Count of daily guest journeys completed on the same date in the previous year, Count of daily guest journeys completed on the same date in the previous year,
segmented by the specified dimension. segmented by the specified dimension.
- name: py_count_csat_score - name: py_total_csat_score_count
data_type: bigint data_type: bigint
description: | description: |
Count of daily guest journeys with CSAT (customer satisfaction score) Count of daily guest journeys with CSAT (customer satisfaction score)