From 22d5b75931f7f9017aad41cfb45b50d023b13692 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oriol=20Roqu=C3=A9=20Paniagua?= Date: Wed, 30 Oct 2024 13:33:11 +0000 Subject: [PATCH] Merged PR 3379: Fixes null on dates # Description Fixes dbt test - I forgot to exclude dates when these are null. # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [NA] I have checked for DRY opportunities with other models and docs. - [NA] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Fixes null on dates Related work items: #23453 --- .../kpis/int_kpis__metric_daily_completed_guest_journeys.sql | 1 + .../kpis/int_kpis__metric_daily_started_guest_journeys.sql | 1 + 2 files changed, 2 insertions(+) diff --git a/models/intermediate/kpis/int_kpis__metric_daily_completed_guest_journeys.sql b/models/intermediate/kpis/int_kpis__metric_daily_completed_guest_journeys.sql index df5dd0c..502f9b3 100644 --- a/models/intermediate/kpis/int_kpis__metric_daily_completed_guest_journeys.sql +++ b/models/intermediate/kpis/int_kpis__metric_daily_completed_guest_journeys.sql @@ -20,4 +20,5 @@ left join {{ ref("int_kpis__dimension_daily_accommodation") }} as icmas on icuh.id_deal = icmas.id_deal and icvr.verification_estimated_completed_date_utc = icmas.date +where icvr.verification_estimated_completed_date_utc is not null group by 1, 2, 3, 4 diff --git a/models/intermediate/kpis/int_kpis__metric_daily_started_guest_journeys.sql b/models/intermediate/kpis/int_kpis__metric_daily_started_guest_journeys.sql index 31e0342..037c0ab 100644 --- a/models/intermediate/kpis/int_kpis__metric_daily_started_guest_journeys.sql +++ b/models/intermediate/kpis/int_kpis__metric_daily_started_guest_journeys.sql @@ -20,4 +20,5 @@ left join {{ ref("int_kpis__dimension_daily_accommodation") }} as icmas on icuh.id_deal = icmas.id_deal and icvr.verification_estimated_started_date_utc = icmas.date +where icvr.verification_estimated_started_date_utc is not null group by 1, 2, 3, 4