counterweight/data-dwh-dbt-project
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

signal model deprecation more clearly, unlock a few tests

Browse source
This commit is contained in:
Pablo Martin 2024-10-08 17:44:31 +02:00
parent ea4274b37c
commit 09fe9ded77
2 changed files with 62 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

22
models/reporting/edeposit/edeposit__guesty_verifications.sql
View file

@ -1,14 +1,8 @@
with
int_athena__verifications_with_fees as (
select * from {{ ref("int_athena__verifications_with_fees") }}
)
select
avf.id_verification as id_verification,
avf.id_booking as id_booking,
avf.verification_status as verification_status,
avf.is_cancelled as is_cancelled,
avf.ok_status_fee_in_gbp as ok_status_fee_in_gbp,
avf.created_date_utc as created_date_utc,
avf.checkout_date_utc as checkout_date_utc
from int_athena__verifications_with_fees avf
/*
This model here should not exist and will be deprecated. Downstream dependencies
should switch to reading from the new `athena__verification_fees`. The model
remains here as pointer to the new one to give downstream dependencies time to switch.
*/
with athena__verification_fees as (select * from {{ ref("athena__verification_fees") }})
select *
from athena__verification_fees

102
models/reporting/edeposit/schema.yml
View file

@ -12,30 +12,30 @@ models:
- name: id_verification
data_type: text
description: "unique Superhog generated id for this verification"
# tests:
# - unique
# - not_null
tests:
- unique
- not_null
- name: id_booking
data_type: text
description: "unique Superhog generated id for a booking.
note that there might be duplicate bookings on the original data
but we remove them keeping only the verification with the most recent update."
# tests:
# - not_null
# - unique
tests:
- not_null
- unique
- name: id_user_partner
data_type: text
description: "unique Superhog generated id for partner"
# tests:
# - not_null
tests:
- not_null
- name: id_accommodation
data_type: text
description: "unique Superhog generated id for a listing"
# tests:
# - not_null
tests:
- not_null
- name: listing_town
data_type: text
@ -64,8 +64,8 @@ models:
- name: currency
data_type: text
description: "currency in which the transaction actually happened"
# tests:
# - not_null
tests:
- not_null
- name: nightly_fee_local
data_type: double precision
@ -78,62 +78,62 @@ models:
- name: ok_status_fee_in_txn_currency
data_type: numeric
description: "fee charged in used currency for approved or flagged verifications and not cancelled"
# tests:
# - not_null
# - dbt_expectations.expect_column_values_to_be_between:
# min_value: 0
# strictly: false
tests:
- not_null
- dbt_expectations.expect_column_values_to_be_between:
min_value: 0
strictly: false
- name: ok_status_fee_in_gbp
data_type: numeric
description: "fee charged in gbp for approved or flagged verifications and not cancelled"
# tests:
# - not_null
# - dbt_expectations.expect_column_values_to_be_between:
# min_value: 0
# strictly: false
tests:
- not_null
- dbt_expectations.expect_column_values_to_be_between:
min_value: 0
strictly: false
- name: rejected_fee_in_txn_currency
data_type: numeric
description: "fee charged in used currency for rejected verifications"
# tests:
# - not_null
# - dbt_expectations.expect_column_values_to_be_between:
# min_value: 0
# strictly: false
tests:
- not_null
- dbt_expectations.expect_column_values_to_be_between:
min_value: 0
strictly: false
- name: rejected_fee_in_gbp
data_type: numeric
description: "fee charged in gbp for rejected verifications"
# tests:
# - not_null
# - dbt_expectations.expect_column_values_to_be_between:
# min_value: 0
# strictly: false
tests:
- not_null
- dbt_expectations.expect_column_values_to_be_between:
min_value: 0
strictly: false
- name: cancelled_fee_in_txn_currency
data_type: numeric
description: "fee charged in used currency for cancelled verifications"
# tests:
# - not_null
# - dbt_expectations.expect_column_values_to_be_between:
# min_value: 0
# strictly: false
tests:
- not_null
- dbt_expectations.expect_column_values_to_be_between:
min_value: 0
strictly: false
- name: cancelled_fee_in_gbp
data_type: numeric
description: "fee charged in gbp for cancelled verifications"
# tests:
# - not_null
# - dbt_expectations.expect_column_values_to_be_between:
# min_value: 0
# strictly: false
tests:
- not_null
- dbt_expectations.expect_column_values_to_be_between:
min_value: 0
strictly: false
- name: created_date_utc
data_type: date
description: "Date of creation of the verification in the system"
# tests:
# - not_null
tests:
- not_null
- name: cancelled_date_utc
data_type: date
@ -142,20 +142,26 @@ models:
- name: checkin_date_utc
data_type: date
description: "Date of checkin for the booking"
# tests:
# - not_null
tests:
- not_null
- name: checkout_date_utc
data_type: date
description: "Date of checkout for the booking"
# tests:
# - not_null
tests:
- not_null
- name: edeposit__guesty_verifications
description: "This table shows all verification for Guesty.
The charged fee is 2GBP per booked night if booking is approved
(considered 1 night when the checkin and checkout are on the same day),
to be charged on checkout."
latest_version: 1
versions:
- v: 1
deprecation_date: "2024-10-15T00:00:00Z"
config:
alias: edeposit__guesty_verifications
columns:
- name: id_verification
data_type: text