Merged PR 3810: Adds is_end_of_month_or_yesterday for Main KPIs
# Description Adds `is_end_of_month_or_yesterday` for Main KPIs. Apparently, the fact that we do not show the ongoing value of the month on some tabs of Main KPIs is the main blocker for Ben C to consistently use Main KPIs, which he actually retrieves from the SH legacy reporting. Since I'm sceptical about the data shown there, I want to remove this blocker. It will require a small PR on PBI as well. # Checklist - [X] The edited models and dependants run properly with production data. - [X] The edited models are sufficiently documented. - [X] The edited models contain PK tests, and I've ran and passed them. - [X] I have checked for DRY opportunities with other models and docs. - [NA] I've picked the right materialization for the affected models. # Other - [ ] Check if a full-refresh is required after this PR is merged. Related work items: #25342
This commit is contained in:
parent
8586dc2aec
commit
06603d01e2
8 changed files with 43 additions and 4 deletions
|
|
@ -103,6 +103,13 @@ models:
|
|||
tests:
|
||||
- not_null
|
||||
|
||||
- name: is_yesterday
|
||||
data_type: boolean
|
||||
description: |
|
||||
True if the date is yesterday, false otherwise.
|
||||
tests:
|
||||
- not_null
|
||||
|
||||
- name: int_kpis__agg_dates_main_kpis
|
||||
description: |
|
||||
This model provides the skeleton of dates and dimensions needed for Main KPIs display.
|
||||
|
|
@ -188,6 +195,13 @@ models:
|
|||
tests:
|
||||
- not_null
|
||||
|
||||
- name: is_end_of_month_or_yesterday
|
||||
data_type: boolean
|
||||
description: |
|
||||
True if the date is the end of the month OR yesterday, false otherwise.
|
||||
tests:
|
||||
- not_null
|
||||
|
||||
- name: int_kpis__lifecycle_daily_accommodation
|
||||
description: |
|
||||
This model computes the daily lifecycle segment for each accommodation, also known as
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue