From 2662527790ce5b0e90be6d8736c213f0af61c78a Mon Sep 17 00:00:00 2001 From: uri Date: Thu, 5 Sep 2024 16:17:05 +0200 Subject: [PATCH 1/3] Enable By Billing Country dimension in prod --- macros/business_kpis_configuration.sql | 1 + 1 file changed, 1 insertion(+) diff --git a/macros/business_kpis_configuration.sql b/macros/business_kpis_configuration.sql index 63ebfe3..dec8884 100644 --- a/macros/business_kpis_configuration.sql +++ b/macros/business_kpis_configuration.sql @@ -30,6 +30,7 @@ Additionally, it provides a proper display name for reporting purposes. {% set dimensions = [ {"dimension": "'global'", "dimension_display": "'Global'"}, {"dimension": "'by_number_of_listings'", "dimension_display": "'By # of Listings Booked in 12 Months'"} + {"dimension": "'by_billing_country'", "dimension_value": "By Billing Country"} ] %} {{ return(dimensions) }} {% endmacro %} \ No newline at end of file From 05058f9e052cb3ca6fe42a0da68441d134a97c57 Mon Sep 17 00:00:00 2001 From: uri Date: Thu, 5 Sep 2024 16:18:49 +0200 Subject: [PATCH 2/3] Fix - wrong config --- macros/business_kpis_configuration.sql | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/macros/business_kpis_configuration.sql b/macros/business_kpis_configuration.sql index dec8884..d8066e5 100644 --- a/macros/business_kpis_configuration.sql +++ b/macros/business_kpis_configuration.sql @@ -29,8 +29,8 @@ Additionally, it provides a proper display name for reporting purposes. {% macro get_kpi_dimensions_for_production() %} {% set dimensions = [ {"dimension": "'global'", "dimension_display": "'Global'"}, - {"dimension": "'by_number_of_listings'", "dimension_display": "'By # of Listings Booked in 12 Months'"} - {"dimension": "'by_billing_country'", "dimension_value": "By Billing Country"} + {"dimension": "'by_number_of_listings'", "dimension_display": "'By # of Listings Booked in 12 Months'"}, + {"dimension": "'by_billing_country'", "dimension_value": "'By Billing Country'"} ] %} {{ return(dimensions) }} {% endmacro %} \ No newline at end of file From 836be7903b7e795c67f651f0f65ae79e556e7120 Mon Sep 17 00:00:00 2001 From: uri Date: Thu, 5 Sep 2024 16:34:17 +0200 Subject: [PATCH 3/3] Fix config - again --- macros/business_kpis_configuration.sql | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/macros/business_kpis_configuration.sql b/macros/business_kpis_configuration.sql index d8066e5..fe3956c 100644 --- a/macros/business_kpis_configuration.sql +++ b/macros/business_kpis_configuration.sql @@ -30,7 +30,7 @@ Additionally, it provides a proper display name for reporting purposes. {% set dimensions = [ {"dimension": "'global'", "dimension_display": "'Global'"}, {"dimension": "'by_number_of_listings'", "dimension_display": "'By # of Listings Booked in 12 Months'"}, - {"dimension": "'by_billing_country'", "dimension_value": "'By Billing Country'"} + {"dimension": "'by_billing_country'", "dimension_display": "'By Billing Country'"} ] %} {{ return(dimensions) }} {% endmacro %} \ No newline at end of file