From 5840a85dedcab8cf3f9ac081dd9532f9c60115b3 Mon Sep 17 00:00:00 2001 From: counterweight Date: Wed, 6 Sep 2023 14:26:25 +0200 Subject: [PATCH] Some renaming --- camisatoshi_wordpress_reports/controllers.py | 4 ++-- .../report_building.py | 22 +++++++++---------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/camisatoshi_wordpress_reports/controllers.py b/camisatoshi_wordpress_reports/controllers.py index 1b5bc30..2073ec9 100644 --- a/camisatoshi_wordpress_reports/controllers.py +++ b/camisatoshi_wordpress_reports/controllers.py @@ -14,7 +14,7 @@ from camisatoshi_wordpress_reports.constants import ( bbo_royalty_fee, ) from camisatoshi_wordpress_reports.report_building import ( - ReportChainBuilder, + OrderObtentionChainBuilder, WoocomerceOrderScope, keep_orders_containing_sku, ) @@ -134,7 +134,7 @@ def generate_um_report( def generate_sku_report(start_date, end_date, sku): logger.info(f"Fetching orders between {start_date} and {end_date}.") - report_chain_builder = ReportChainBuilder() + report_chain_builder = OrderObtentionChainBuilder() report_chain_builder.add_order_fetching_step( wc_order_scope=WoocomerceOrderScope( diff --git a/camisatoshi_wordpress_reports/report_building.py b/camisatoshi_wordpress_reports/report_building.py index 293a355..72f406a 100644 --- a/camisatoshi_wordpress_reports/report_building.py +++ b/camisatoshi_wordpress_reports/report_building.py @@ -84,7 +84,7 @@ def validate_orders_satisfy_metadata_filter( return True -class ReportChain: +class OrderObtentionChain: def __init__(self): self.order_fetching_step = None self.order_filtering_steps = [] @@ -127,37 +127,37 @@ class ReportChain: raise ValueError("Error during order validation step.") -class ReportChainBuilder: +class OrderObtentionChainBuilder: def __init__(self): - self._wip_report_chain = ReportChain() + self._wip_order_obtention_chain = OrderObtentionChain() def add_order_fetching_step( self, wc_order_scope: WoocomerceOrderScope - ) -> "ReportChainBuilder": + ) -> "OrderObtentionChainBuilder": """ Define a scope of orders to get from Woocomerce. """ self._order_scope = wc_order_scope - self._wip_report_chain.order_fetching_step = partial( + self._wip_order_obtention_chain.order_fetching_step = partial( fetch_orders_from_wc, wc_order_scope=wc_order_scope ) return self - def add_order_filtering_step(self, step) -> "ReportChainBuilder": + def add_order_filtering_step(self, step) -> "OrderObtentionChainBuilder": - self._wip_report_chain.order_filtering_steps.append(step) + self._wip_order_obtention_chain.order_filtering_steps.append(step) return self - def add_order_validation_step(self, step) -> "ReportChainBuilder": + def add_order_validation_step(self, step) -> "OrderObtentionChainBuilder": - self._wip_report_chain.order_validation_steps.append(step) + self._wip_order_obtention_chain.order_validation_steps.append(step) return self - def get_report_chain(self) -> ReportChain: + def get_report_chain(self) -> OrderObtentionChain: - return self._wip_report_chain + return self._wip_order_obtention_chain