arbret/frontend/app/trades/page.tsx
counterweight b86b506d72
Refactor frontend: Add reusable hooks and components
- Created useAsyncData hook: Eliminates repetitive data fetching boilerplate
  - Handles loading, error, and data state automatically
  - Supports enabled/disabled fetching
  - Provides refetch function

- Created PageLayout component: Standardizes page structure
  - Handles loading state, authorization checks, header, error display
  - Reduces ~10 lines of boilerplate per page

- Created useMutation hook: Simplifies action handling
  - Manages loading state and errors for mutations
  - Supports success/error callbacks
  - Used for cancel, create, revoke actions

- Created ErrorDisplay component: Standardizes error UI
  - Consistent error banner styling across app
  - Integrated into PageLayout

- Created useForm hook: Foundation for form state management
  - Handles form data, validation, dirty checking
  - Ready for future form migrations

- Migrated pages to use new patterns:
  - invites/page.tsx: useAsyncData + PageLayout
  - trades/page.tsx: useAsyncData + PageLayout + useMutation
  - trades/[id]/page.tsx: useAsyncData
  - admin/price-history/page.tsx: useAsyncData + PageLayout
  - admin/invites/page.tsx: useMutation for create/revoke

Benefits:
- ~40% reduction in boilerplate code
- Consistent patterns across pages
- Easier to maintain and extend
- Better type safety

All tests passing (32 frontend, 33 e2e)
2025-12-25 21:30:35 +01:00

339 lines
13 KiB
TypeScript

"use client";
import { useState, CSSProperties } from "react";
import { useRouter } from "next/navigation";
import { Permission } from "../auth-context";
import { tradesApi } from "../api";
import { PageLayout } from "../components/PageLayout";
import { SatsDisplay } from "../components/SatsDisplay";
import { useRequireAuth } from "../hooks/useRequireAuth";
import { useAsyncData } from "../hooks/useAsyncData";
import { useMutation } from "../hooks/useMutation";
import { formatDateTime } from "../utils/date";
import { formatEur, getTradeStatusDisplay } from "../utils/exchange";
import { typographyStyles, badgeStyles, buttonStyles, tradeCardStyles } from "../styles/shared";
export default function TradesPage() {
const router = useRouter();
const { user, isLoading, isAuthorized } = useRequireAuth({
requiredPermission: Permission.VIEW_OWN_EXCHANGES,
fallbackRedirect: "/",
});
const {
data: trades = [],
isLoading: isLoadingTrades,
error,
refetch: fetchTrades,
} = useAsyncData(() => tradesApi.getTrades(), {
enabled: !!user && isAuthorized,
initialData: [],
});
const [cancellingId, setCancellingId] = useState<string | null>(null);
const [confirmCancelId, setConfirmCancelId] = useState<string | null>(null);
const { mutate: cancelTrade } = useMutation(
(publicId: string) => tradesApi.cancelTrade(publicId),
{
onSuccess: () => {
fetchTrades();
setConfirmCancelId(null);
},
}
);
const handleCancel = async (publicId: string) => {
setCancellingId(publicId);
try {
await cancelTrade(publicId);
} finally {
setCancellingId(null);
}
};
const upcomingTrades = trades.filter(
(t) => t.status === "booked" && new Date(t.slot_start) > new Date()
);
const pastOrFinalTrades = trades.filter(
(t) => t.status !== "booked" || new Date(t.slot_start) <= new Date()
);
return (
<PageLayout
currentPage="trades"
isLoading={isLoading}
isAuthorized={isAuthorized}
error={error}
contentStyle={styles.content}
>
<h1 style={typographyStyles.pageTitle}>My Trades</h1>
<p style={typographyStyles.pageSubtitle}>View and manage your Bitcoin trades</p>
{isLoadingTrades ? (
<div style={tradeCardStyles.emptyState}>Loading trades...</div>
) : trades.length === 0 ? (
<div style={tradeCardStyles.emptyState}>
<p>You don&apos;t have any trades yet.</p>
<a href="/exchange" style={styles.emptyStateLink}>
Start trading
</a>
</div>
) : (
<>
{/* Upcoming Trades */}
{upcomingTrades.length > 0 && (
<div style={styles.section}>
<h2 style={styles.sectionTitle}>Upcoming ({upcomingTrades.length})</h2>
<div style={tradeCardStyles.tradeList}>
{upcomingTrades.map((trade) => {
const status = getTradeStatusDisplay(trade.status);
const isBuy = trade.direction === "buy";
return (
<div key={trade.id} style={tradeCardStyles.tradeCard}>
<div style={tradeCardStyles.tradeHeader}>
<div style={tradeCardStyles.tradeInfo}>
<div style={tradeCardStyles.tradeTime}>
{formatDateTime(trade.slot_start)}
</div>
<div style={tradeCardStyles.tradeDetails}>
<span
style={{
...tradeCardStyles.directionBadge,
background: isBuy
? "rgba(74, 222, 128, 0.15)"
: "rgba(248, 113, 113, 0.15)",
color: isBuy ? "#4ade80" : "#f87171",
}}
>
{isBuy ? "BUY BTC" : "SELL BTC"}
</span>
<span
style={{
...tradeCardStyles.directionBadge,
background: "rgba(167, 139, 250, 0.15)",
color: "#a78bfa",
}}
>
{isBuy
? `Receive via ${trade.bitcoin_transfer_method === "onchain" ? "Onchain" : "Lightning"}`
: `Send via ${trade.bitcoin_transfer_method === "onchain" ? "Onchain" : "Lightning"}`}
</span>
<span style={tradeCardStyles.amount}>
{formatEur(trade.eur_amount)}
</span>
<span style={tradeCardStyles.arrow}></span>
<span style={tradeCardStyles.satsAmount}>
<SatsDisplay sats={trade.sats_amount} />
</span>
</div>
<div style={tradeCardStyles.rateRow}>
<span style={tradeCardStyles.rateLabel}>Rate:</span>
<span style={tradeCardStyles.rateValue}>
{trade.agreed_price_eur.toLocaleString("de-DE", {
maximumFractionDigits: 0,
})}
/BTC
</span>
</div>
<span
style={{
...badgeStyles.badge,
background: status.bgColor,
color: status.textColor,
marginTop: "0.5rem",
}}
>
{status.text}
</span>
</div>
<div style={tradeCardStyles.buttonGroup}>
{trade.status === "booked" && (
<>
{confirmCancelId === trade.public_id ? (
<>
<button
onClick={(e) => {
e.stopPropagation();
handleCancel(trade.public_id);
}}
disabled={cancellingId === trade.public_id}
style={styles.confirmButton}
>
{cancellingId === trade.public_id ? "..." : "Confirm"}
</button>
<button
onClick={(e) => {
e.stopPropagation();
setConfirmCancelId(null);
}}
style={buttonStyles.secondaryButton}
>
No
</button>
</>
) : (
<button
onClick={(e) => {
e.stopPropagation();
setConfirmCancelId(trade.public_id);
}}
style={buttonStyles.secondaryButton}
>
Cancel
</button>
)}
</>
)}
<button
onClick={(e) => {
e.stopPropagation();
router.push(`/trades/${trade.public_id}`);
}}
style={styles.viewDetailsButton}
>
View Details
</button>
</div>
</div>
</div>
);
})}
</div>
</div>
)}
{/* Past/Completed/Cancelled Trades */}
{pastOrFinalTrades.length > 0 && (
<div style={styles.section}>
<h2 style={typographyStyles.sectionTitleMuted}>
History ({pastOrFinalTrades.length})
</h2>
<div style={tradeCardStyles.tradeList}>
{pastOrFinalTrades.map((trade) => {
const status = getTradeStatusDisplay(trade.status);
const isBuy = trade.direction === "buy";
return (
<div
key={trade.id}
style={{
...tradeCardStyles.tradeCard,
...styles.tradeCardPast,
}}
>
<div style={tradeCardStyles.tradeTime}>
{formatDateTime(trade.slot_start)}
</div>
<div style={tradeCardStyles.tradeDetails}>
<span
style={{
...tradeCardStyles.directionBadge,
background: isBuy
? "rgba(74, 222, 128, 0.1)"
: "rgba(248, 113, 113, 0.1)",
color: isBuy ? "rgba(74, 222, 128, 0.7)" : "rgba(248, 113, 113, 0.7)",
}}
>
{isBuy ? "BUY BTC" : "SELL BTC"}
</span>
<span
style={{
...tradeCardStyles.directionBadge,
background: "rgba(167, 139, 250, 0.1)",
color: "rgba(167, 139, 250, 0.7)",
}}
>
{isBuy
? `Receive via ${trade.bitcoin_transfer_method === "onchain" ? "Onchain" : "Lightning"}`
: `Send via ${trade.bitcoin_transfer_method === "onchain" ? "Onchain" : "Lightning"}`}
</span>
<span style={tradeCardStyles.amount}>{formatEur(trade.eur_amount)}</span>
<span style={tradeCardStyles.arrow}></span>
<span style={tradeCardStyles.satsAmount}>
<SatsDisplay sats={trade.sats_amount} />
</span>
</div>
<div style={tradeCardStyles.buttonGroup}>
<span
style={{
...badgeStyles.badge,
background: status.bgColor,
color: status.textColor,
}}
>
{status.text}
</span>
<button
onClick={(e) => {
e.stopPropagation();
router.push(`/trades/${trade.public_id}`);
}}
style={styles.viewDetailsButton}
>
View Details
</button>
</div>
</div>
);
})}
</div>
</div>
)}
</>
)}
</PageLayout>
);
}
// Page-specific styles (trade card styles are shared via tradeCardStyles)
const styles: Record<string, CSSProperties> = {
content: {
flex: 1,
padding: "2rem",
maxWidth: "800px",
margin: "0 auto",
width: "100%",
},
section: {
marginBottom: "2rem",
},
sectionTitle: {
fontFamily: "'DM Sans', system-ui, sans-serif",
fontSize: "1.1rem",
fontWeight: 500,
color: "#fff",
marginBottom: "1rem",
},
tradeCardPast: {
opacity: 0.6,
background: "rgba(255, 255, 255, 0.01)",
},
confirmButton: {
fontFamily: "'DM Sans', system-ui, sans-serif",
padding: "0.35rem 0.75rem",
fontSize: "0.75rem",
background: "rgba(239, 68, 68, 0.2)",
border: "1px solid rgba(239, 68, 68, 0.3)",
borderRadius: "6px",
color: "#f87171",
cursor: "pointer",
transition: "all 0.2s",
},
emptyStateLink: {
color: "#a78bfa",
textDecoration: "none",
},
viewDetailsButton: {
fontFamily: "'DM Sans', system-ui, sans-serif",
padding: "0.35rem 0.75rem",
fontSize: "0.75rem",
background: "rgba(167, 139, 250, 0.15)",
border: "1px solid rgba(167, 139, 250, 0.3)",
borderRadius: "6px",
color: "#a78bfa",
cursor: "pointer",
transition: "all 0.2s",
},
};