first round of review

frontend/app/auth-context.tsx

@@ -2,6 +2,8 @@
 
 import { createContext, useContext, useState, useEffect, ReactNode } from "react";
 
+const API_URL = process.env.NEXT_PUBLIC_API_URL || "http://localhost:8000";
+
 interface User {
   id: number;
   email: string;
@@ -9,54 +11,43 @@ interface User {
 
 interface AuthContextType {
   user: User | null;
-  token: string | null;
   isLoading: boolean;
   login: (email: string, password: string) => Promise<void>;
   register: (email: string, password: string) => Promise<void>;
-  logout: () => void;
+  logout: () => Promise<void>;
 }
 
 const AuthContext = createContext<AuthContextType | null>(null);
 
 export function AuthProvider({ children }: { children: ReactNode }) {
   const [user, setUser] = useState<User | null>(null);
-  const [token, setToken] = useState<string | null>(null);
   const [isLoading, setIsLoading] = useState(true);
 
   useEffect(() => {
-    const storedToken = localStorage.getItem("token");
-    if (storedToken) {
-      setToken(storedToken);
-      fetchUser(storedToken);
-    } else {
-      setIsLoading(false);
-    }
+    checkAuth();
   }, []);
 
-  const fetchUser = async (authToken: string) => {
+  const checkAuth = async () => {
     try {
-      const res = await fetch("http://localhost:8000/api/auth/me", {
-        headers: { Authorization: `Bearer ${authToken}` },
+      const res = await fetch(`${API_URL}/api/auth/me`, {
+        credentials: "include",
       });
       if (res.ok) {
         const userData = await res.json();
         setUser(userData);
-      } else {
-        localStorage.removeItem("token");
-        setToken(null);
       }
     } catch {
-      localStorage.removeItem("token");
-      setToken(null);
+      // Not authenticated
     } finally {
       setIsLoading(false);
     }
   };
 
   const login = async (email: string, password: string) => {
-    const res = await fetch("http://localhost:8000/api/auth/login", {
+    const res = await fetch(`${API_URL}/api/auth/login`, {
       method: "POST",
       headers: { "Content-Type": "application/json" },
+      credentials: "include",
       body: JSON.stringify({ email, password }),
     });
 
@@ -65,16 +56,15 @@ export function AuthProvider({ children }: { children: ReactNode }) {
       throw new Error(error.detail || "Login failed");
     }
 
-    const data = await res.json();
-    localStorage.setItem("token", data.access_token);
-    setToken(data.access_token);
-    setUser(data.user);
+    const userData = await res.json();
+    setUser(userData);
   };
 
   const register = async (email: string, password: string) => {
-    const res = await fetch("http://localhost:8000/api/auth/register", {
+    const res = await fetch(`${API_URL}/api/auth/register`, {
       method: "POST",
       headers: { "Content-Type": "application/json" },
+      credentials: "include",
       body: JSON.stringify({ email, password }),
     });
 
@@ -83,20 +73,20 @@ export function AuthProvider({ children }: { children: ReactNode }) {
       throw new Error(error.detail || "Registration failed");
     }
 
-    const data = await res.json();
-    localStorage.setItem("token", data.access_token);
-    setToken(data.access_token);
-    setUser(data.user);
+    const userData = await res.json();
+    setUser(userData);
   };
 
-  const logout = () => {
-    localStorage.removeItem("token");
-    setToken(null);
+  const logout = async () => {
+    await fetch(`${API_URL}/api/auth/logout`, {
+      method: "POST",
+      credentials: "include",
+    });
     setUser(null);
   };
 
   return (
-    <AuthContext.Provider value={{ user, token, isLoading, login, register, logout }}>
+    <AuthContext.Provider value={{ user, isLoading, login, register, logout }}>
       {children}
     </AuthContext.Provider>
   );
@@ -109,4 +99,3 @@ export function useAuth() {
   }
   return context;
 }
-