tests passing

backend/tests/test_counter.py

@@ -1,60 +1,128 @@
 import pytest
-from httpx import ASGITransport, AsyncClient
-from sqlalchemy.ext.asyncio import create_async_engine, async_sessionmaker
-
-from database import Base, get_db
-from main import app
-
-TEST_DATABASE_URL = "sqlite+aiosqlite:///:memory:"
+import uuid
 
 
-@pytest.fixture
-async def client():
-    engine = create_async_engine(TEST_DATABASE_URL)
-    async_session = async_sessionmaker(engine, expire_on_commit=False)
+def unique_email(prefix: str = "counter") -> str:
+    """Generate a unique email for tests sharing the same database."""
+    return f"{prefix}-{uuid.uuid4().hex[:8]}@example.com"
 
-    async with engine.begin() as conn:
-        await conn.run_sync(Base.metadata.create_all)
 
-    async def override_get_db():
-        async with async_session() as session:
-            yield session
+async def create_user_and_get_headers(client, email: str = None) -> dict:
+    """Create a user and return auth headers for authenticated requests."""
+    if email is None:
+        email = unique_email()
+    response = await client.post(
+        "/api/auth/register",
+        json={"email": email, "password": "testpass123"},
+    )
+    token = response.json()["access_token"]
+    return {"Authorization": f"Bearer {token}"}
 
-    app.dependency_overrides[get_db] = override_get_db
 
-    async with AsyncClient(transport=ASGITransport(app=app), base_url="http://test") as c:
-        yield c
-
-    app.dependency_overrides.clear()
-    await engine.dispose()
+# Protected endpoint tests - without auth
+@pytest.mark.asyncio
+async def test_get_counter_requires_auth(client):
+    response = await client.get("/api/counter")
+    assert response.status_code in [401, 403]
 
 
 @pytest.mark.asyncio
-async def test_get_counter_initial(client):
-    response = await client.get("/api/counter")
+async def test_increment_counter_requires_auth(client):
+    response = await client.post("/api/counter/increment")
+    assert response.status_code in [401, 403]
+
+
+@pytest.mark.asyncio
+async def test_get_counter_invalid_token(client):
+    response = await client.get(
+        "/api/counter",
+        headers={"Authorization": "Bearer invalidtoken"},
+    )
+    assert response.status_code == 401
+
+
+@pytest.mark.asyncio
+async def test_increment_counter_invalid_token(client):
+    response = await client.post(
+        "/api/counter/increment",
+        headers={"Authorization": "Bearer invalidtoken"},
+    )
+    assert response.status_code == 401
+
+
+# Authenticated counter tests
+@pytest.mark.asyncio
+async def test_get_counter_authenticated(client):
+    auth_headers = await create_user_and_get_headers(client)
+    response = await client.get("/api/counter", headers=auth_headers)
     assert response.status_code == 200
-    assert response.json() == {"value": 0}
+    assert "value" in response.json()
 
 
 @pytest.mark.asyncio
 async def test_increment_counter(client):
-    response = await client.post("/api/counter/increment")
+    auth_headers = await create_user_and_get_headers(client)
+    
+    # Get current value
+    before = await client.get("/api/counter", headers=auth_headers)
+    before_value = before.json()["value"]
+    
+    # Increment
+    response = await client.post("/api/counter/increment", headers=auth_headers)
     assert response.status_code == 200
-    assert response.json() == {"value": 1}
+    assert response.json()["value"] == before_value + 1
 
 
 @pytest.mark.asyncio
 async def test_increment_counter_multiple(client):
-    await client.post("/api/counter/increment")
-    await client.post("/api/counter/increment")
-    response = await client.post("/api/counter/increment")
-    assert response.json() == {"value": 3}
+    auth_headers = await create_user_and_get_headers(client)
+    
+    # Get starting value
+    before = await client.get("/api/counter", headers=auth_headers)
+    start = before.json()["value"]
+    
+    # Increment 3 times
+    await client.post("/api/counter/increment", headers=auth_headers)
+    await client.post("/api/counter/increment", headers=auth_headers)
+    response = await client.post("/api/counter/increment", headers=auth_headers)
+    
+    assert response.json()["value"] == start + 3
 
 
 @pytest.mark.asyncio
 async def test_get_counter_after_increment(client):
-    await client.post("/api/counter/increment")
-    await client.post("/api/counter/increment")
-    response = await client.get("/api/counter")
-    assert response.json() == {"value": 2}
+    auth_headers = await create_user_and_get_headers(client)
+    
+    before = await client.get("/api/counter", headers=auth_headers)
+    start = before.json()["value"]
+    
+    await client.post("/api/counter/increment", headers=auth_headers)
+    await client.post("/api/counter/increment", headers=auth_headers)
+    
+    response = await client.get("/api/counter", headers=auth_headers)
+    assert response.json()["value"] == start + 2
 
+
+# Counter is shared between users
+@pytest.mark.asyncio
+async def test_counter_shared_between_users(client):
+    headers1 = await create_user_and_get_headers(client, unique_email("share1"))
+    
+    # Get starting value
+    before = await client.get("/api/counter", headers=headers1)
+    start = before.json()["value"]
+    
+    await client.post("/api/counter/increment", headers=headers1)
+    await client.post("/api/counter/increment", headers=headers1)
+    
+    # Second user sees the increments
+    headers2 = await create_user_and_get_headers(client, unique_email("share2"))
+    response = await client.get("/api/counter", headers=headers2)
+    assert response.json()["value"] == start + 2
+    
+    # Second user increments
+    await client.post("/api/counter/increment", headers=headers2)
+    
+    # First user sees the increment
+    response = await client.get("/api/counter", headers=headers1)
+    assert response.json()["value"] == start + 3